Skip to content

New deploy command #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
josephjclark wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

New deploy command #1184

josephjclark wants to merge 14 commits into from

Conversation

@josephjclark
Copy link
Collaborator

@josephjclark josephjclark commented Dec 18, 2025 •
edited
Loading

This PR basically makes deploy --beta functional (or it will do, when I finish)

Fixes #1165

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

@github-project-automation github-project-automation bot moved this to New Issues in v2 Dec 18, 2025
@josephjclark josephjclark changed the base branch from main to release/next December 25, 2025 16:31
@josephjclark
Copy link
Collaborator Author

josephjclark commented Dec 25, 2025

TODO: add an env var PREFER_NEW_SYNC

This can be set in .env for projects which use the new sync stuff, and mean you don't need to pass the --beta flag

This should not be set on projects which need github sync

Base automatically changed from release/next to main January 4, 2026 20:19
@josephjclark
Copy link
Collaborator Author

josephjclark commented Jan 14, 2026

At this point deploy is almost totally written. But after a lot of struggle it's working!

I hit a major problem in projects: turns out we were serializing the v1 state file in the wrong format! Which meant that what I was deploying was getting rejected.

Also hit some problems in merge code where not all properties of project and workflow get merged. I knew that was coming, but I'd totally forgotten it. So far I've dropped in a quick fix

Still to do:

  • handle divergence
  • testing of deploy
  • testing of new project merge stuff (and changeset)
  • deploy from any arbitrary state or project file
  • probably go ahead and add --format to fetch so I can pull a state file raw. Really useful for debugging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

v2
Status: New Issues

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Give deploy --beta some love

2 participants

@josephjclark